Tests: Add system tests for groupadd in test_groupadd.py - #1682
Merged
ikerexxe merged 3 commits intoAug 24, 2026
Conversation
asakure
force-pushed
the
system_tests_groupadd_14_15_16
branch
2 times, most recently
from
July 21, 2026 13:15
4fc8dd1 to
d5658c0
Compare
asakure
marked this pull request as ready for review
July 23, 2026 05:33
asakure
force-pushed
the
system_tests_groupadd_14_15_16
branch
from
August 21, 2026 14:07
d5658c0 to
79a1f9f
Compare
ikerexxe
reviewed
Aug 24, 2026
ikerexxe
left a comment
ikerexxe
left a comment
Collaborator
There was a problem hiding this comment.
Some minor things to improve inline.
In addition, the path in the second commit message should be tests/grouptools/groupadd/15_groupadd_invalid_-K_no_=/groupadd.test, no need to add the extra apostrophes
This is Python transformation of the test located in `tests/grouptools/groupadd/14_groupadd_invalid_-K_option/groupadd.test` which checks if `groupadd` fails to create group when invalid key is is mentioned with -K option Signed-off-by: Akshay Sakure <asakure@redhat.com>
This is Python transformation of the test located in `tests/grouptools/groupadd/15_groupadd_invalid_-K_no_=/groupadd.test` which checks if `groupadd` fails to create group with -K option when argument is missing the equals(=) sign Signed-off-by: Akshay Sakure <asakure@redhat.com>
asakure
force-pushed
the
system_tests_groupadd_14_15_16
branch
from
August 24, 2026 09:27
79a1f9f to
661cf68
Compare
Contributor
Author
|
Hi @ikerexxe I have done the suggested changes & re-pushed, kindly review. TIA! |
ikerexxe
reviewed
Aug 24, 2026
This is Python transformation of the test located in `tests/grouptools/groupadd/16_groupadd_existing_group/groupadd.test` which checks that `groupadd` fails to create group when group already exists Signed-off-by: Akshay Sakure <asakure@redhat.com>
asakure
force-pushed
the
system_tests_groupadd_14_15_16
branch
from
August 24, 2026 11:11
661cf68 to
a705229
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add system tests for groupadd in test_groupadd.py for
existing bash tests with numbering 14, 15, 16.